Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setForegroundServiceBehavior for persistent websocket service [WPB-11113] #3593

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: setForegroundServiceBehavior for persistent websocket service [WPB-11113] #3593

wants to merge 2 commits into from
+1 −0

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 6, 2024 •
edited by github-actions bot
Loading

BugWPB-11113 [Android] crash on starting foreground service

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Added FOREGROUND_SERVICE_IMMEDIATE flag to persistent websocket service. Doing this, the display of the notification will be immediate.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Nov 6, 2024
@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, alexandreferris, vitorhugods and Garzas and removed request for a team November 6, 2024 10:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (636b570) to head (2c596d0).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ire/android/services/PersistentWebSocketService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3593      +/-   ##
===========================================
- Coverage    45.34%   45.33%   -0.02%     
===========================================
  Files          472      472              
  Lines        15790    15796       +6     
  Branches      2633     2632       -1     
===========================================
+ Hits          7160     7161       +1     
- Misses        7880     7885       +5     
  Partials       750      750
Files with missing lines Coverage Δ
...ire/android/services/PersistentWebSocketService.kt 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636b570...2c596d0. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-staging-compat-pr-3593.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-dev-debug-pr-3593.apk is available for download

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-staging-compat-pr-3593.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-dev-debug-pr-3593.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @codecov-commenter @yamilmedina @MohamadJaara